Cloudef / bemenu

Dynamic menu library and client program inspired by dmenu
GNU General Public License v3.0
1.16k stars 90 forks source link

add option to start vim bindings in normal mode #375

Closed pabloariasal closed 7 months ago

pabloariasal commented 7 months ago

First of all thank you for bemenu, i love it :)

This PR introduces a new command line flag --vim-normal-mode, which changes the initial mode for vim bindings to normal (instead of insert mode, which is the default). This flags makes sense in certain circumstances where there is only a small set of possible options to select from (2-5), and it is just easier to tap j repeatedly instead of fuzzy-finding.

merrittlj commented 7 months ago

Possibly this could be specified as a parameter for the "--binding" flag(ex: "--binding vim normal-mode")? We may want to change the "-e"/"--vim-esc-exits" flag as well to conform to this, but let's see what @Cloudef thinks about this idea before any modifications are made to either flag.

pabloariasal commented 7 months ago

while I can see some benefits in combining all the vim-related options into a single --binding flag this also makes the CLI less intuitive. In my experience these multitoken flags are hard to document and use properly. Two separate toggle flags is as easy as it gets. Agree to wait for @Cloudef's opinion.

Cloudef commented 7 months ago

I think having them as separate flags for now is fine. Lets see if the flags still keep building up.