Cloudef / bemenu

Dynamic menu library and client program inspired by dmenu
GNU General Public License v3.0
1.16k stars 90 forks source link

wayland: ensure bemenu is shown on top of fullscreen windows #376

Closed Consolatis closed 6 months ago

Consolatis commented 6 months ago

Before this patch, wayland compositors that render fullscreen windows between the top and overlay layers would show bemenu behind an active fullscreen window. For other compositors the z-rendering order was undefined.

This change ensures that bemenu will always be on top of other usual windows (including fullscreen ones).

Fixes

Cloudef commented 6 months ago

There used to be security issue related to this in swaylock but I guess it's now ok? https://github.com/swaywm/swaylock/issues/107

Consolatis commented 6 months ago

There used to be security issue related to this in swaylock but I guess it's now ok? swaywm/swaylock#107

Indeed, the current locking protocol ext-session-lock-v1 doesn't use the overlay layer and is completely independent from the layershell protocol.