search

Cloudef / wlc

High-level Wayland compositor library
MIT License
330 stars 58 forks source link

Coding style: use local include #159

Closed abique closed 8 years ago

Earnestly commented 8 years ago

Why? Generally a commit should have an explanation or justification instead of just a blank message with a pithy title...

abique commented 8 years ago

Because #include "" uses relative path. While #include <> uses search path.

abique commented 8 years ago

And by the way you should also include standard headers first, not yours. That way your marcos will not mess with standard headers.

Earnestly commented 8 years ago

Oh I'm not disagreeing but you need explain why in the message body. You also need to explain why using relative paths is better. I would hate to see crap like #include "../foo.h" but that doesn't seem to be what you're advocating here.

abique commented 8 years ago

Do it as it please.

Earnestly commented 8 years ago

@abique I'm not the owner of this repository incase you didn't notice, however, I think asking for a little justification is a reasonable request.

There's really no need to be callow.