Include sys/sysmacros.h for major/minor(3) (Linux)

Cloudef / wlc

High-level Wayland compositor library

MIT License

330 stars 58 forks source link

Include sys/sysmacros.h for major/minor(3) (Linux) #224

Closed Hummer12007 closed 7 years ago

Hummer12007 commented 7 years ago

sys/sysmacros.h implicit inclusion is being deprecated (even with _DEFAULT_SOURCE), so it would cause build breakage on future updates.

See https://bugs.gentoo.org/show_bug.cgi?id=604608 and https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html (also mentioned in glibc news)

Cloudef commented 7 years ago

Do you know if this breaks compile anywhere?

Hummer12007 commented 7 years ago

Well, it (the issue) seems to break the build in gentoo with glibc-2.24 (which is not even keyworded yet), as they decided to patch the implicit include out (again). Same thing happened with 2.23 before (but they have decided to revert it before stabilizing). Who knows what'll happen this time... At the very least, it is compatible with glibc, musl, and uclibc(-ng).

Cloudef commented 7 years ago

Lets merge this and think about it if there are complaints.