ddevault
commented
7 years ago Quick notes just from reading over your description:
(is there anything else the clipboard is used for?).
Images are pretty common. Also perhaps rich text (i.e. libreoffice).
Many applications and toolkits use mime types as x11 targets already though so we might simlpy guess there (not sure if this is a good idea and again, text is probably the only really important clipboard target).
Maybe we could have a hardcoded list of hairy conversions and then fall back on just copying it over? Do you know what other compositors do?
Syncronization works in both directions, right?
nyorain
This adds (basic) synchronization between the xwayland and wayland clipboard. It also fixes some found bugs in the polymorphic data-source implementation and cleans up some aspects of the xwm implementation (mainly removes the global state).
The xselection implementation is nothing beautiful and can be improved. It implements only the absolutely needed functionality and does not care about the icccm spec too much at places (i.e. the given timestamps are probably not always correct and it does not implement INCR data transfer but this is usually not needed).
It only works for text data on the clipboard at the moment but can be easily extended to further types (is there anything else the clipboard is used for?). Note that it cannot be easily extended to support all types in a generic way though since we have to map the TARGETS atoms from x11 to mime types in wayland (and the other way around) and there is probably no general way to do this. Many applications and toolkits use mime types as x11 targets already though so we might simlpy guess there (not sure if this is a good idea and again, text is probably the only really important clipboard target).
Please tell me if there is anything that has to be done to consider this feature done for now. This would additionally need some further testing it works for me with the wlc example and sway (mainly tested with chromium and termite on the both backends) but this is so ugly/easy to get wrong that all testing is appreciated.