search

CloudiDust / wesnoth-cn

Simplified Chinese localization project for the Battle for Wesnoth.
GNU General Public License v2.0
18 stars 8 forks source link

fix text attribute errors #17

Closed celerini closed 2 years ago

celerini commented 2 years ago

Hi,

these errors cause that help is instantly closed.

I noticed using bold instead of italic (somewhere, may be intentionaly, but italic looks readable and zh_TW uses italic there) and Kingdom of Wesnoth (Geography) has two links instead of four, but I don't want to delve too deep...

CloudiDust commented 2 years ago

Thanks for this PR.

It is considered that italic doesn't quite work with CJK typography. CJK fonts don't have embedded "italic" variants (as our characters simply don't have such variants), so "italic" CJK glyphs are algorithm-generated from regular CJK glyphs, and while readable, they look weird.

Thus, to convey the same meaning as italic in CJK, it is better to use a different CJK font that has a similar "feel" to italics, but native to CJK (like Kai Ti or Li Shu), or use the appropriate CJK punctuation marks.

Wesnoth only has one set of bundled CJK fonts (Droid Sans Fallback & Droid Sans Japanese, which is Hei Ti, not Kai Ti or Li Shu), so I chose to use bold instead of italic. This is of course, not an ideal solution. Maybe, I can try using different-colored characters to substitute for italics? Still not ideal, it seems.

There indeed are two links missing in Kingdom of Wesnoth (Geography), thanks for the catch!

celerini commented 2 years ago

Thanks for accepting my PR, thorough explanation of CJK glyphs and adding links into the KoW.