Cloudkibo / Android

0 stars 0 forks source link

When sending documents should it not take me to My Drive instead of Documents #540

Closed jekram closed 7 years ago

jekram commented 7 years ago

When sending documents should it not take me to My Drive instead of Documents

Whatsapp takes me to "Document" image

KiboChat takes me to My Drive image

What is the difference between "Document" and My Drive? Please answer this before working on this bug

Assadbintahir commented 7 years ago

I was unable to reproduce this error. It did not take me to any specific folder.

In my case, only file picker was opened. I myself navigated to different folders.

6

jekram commented 7 years ago

@Assadbintahir

You are incorrect. Try to understand how it works on Whatsapp and does our app works the same way.

sojharo commented 7 years ago

Whatsapp is little bit different here on my device. It took me to Recent instead of Documents. Looks like there are differences for different devices. i.e. some devices have different file explorer. In our case, we had used custom file explorer which starts from "My drive". I would look more into this. For gallery and audio Whatsapp have included their own file explorer that is why it looks different. Here is how whatsapp shows "send document" on my device:

screenshot_2017-03-16-13-40-00

jekram commented 7 years ago

I am fine with what you and @Assadbintahir got. "Open From"

Let's make it consistent for all our users?

sojharo commented 7 years ago

I once again researched on this and tried it on different devices. On some devices, whatsapp takes me to "documents" and on some devices it takes me to "Recent" folder. I then explored and found one third party library for implementing file picker. It automatically shows us all the documents which are on our device. Kindly, let me know if we should go for this library..

https://github.com/DroidNinja/Android-FilePicker

This would remain consistent across all devices. Whatsapp however, is not consistent. Here are screenshots of "Send Document" of whatsapp on two different devices:

Device one: QMobile

screenshot_20170328-174122

Device two: Samsung

screenshot_2017-03-16-13-40-00

sojharo commented 7 years ago

I worked alot on this today. The Android document chooser library didn't work. However, I have changed the code back to "open from". Whatsapp also opens "Documents" on one device and "open from" on other device. I think this is completely dependent on device and not application. It depends on what type of explorer device has installed on it.

jekram commented 7 years ago

So it will be consistent on that device between KiboChat and WhatsApp on what to open?

jekram commented 7 years ago

@sojharo

So it will be consistent on that device between KiboChat and WhatsApp on what to open?

sojharo commented 7 years ago

Yes Sir. It would be consistent between devices. KiboChat also has its builtin file explorer and it can be opened too