search

Cloudkibo / Android

0 stars 0 forks source link

Sidebar can't be accessed from settings screen #545

Closed Assadbintahir closed 7 years ago

Assadbintahir commented 7 years ago

Sidebar can't be accessed from settings screen. It is also unavailable in Unblock and Backup Settings.

1

jekram commented 7 years ago

@Assadbintahir I am not understanding what the issue is. Please explain more

Assadbintahir commented 7 years ago

Sidebar menu cant be accessed when we are in settings screen. As attached in above screenshot

jekram commented 7 years ago

Ok. Thanks

sojharo commented 7 years ago

I have followed the Whatsapp model here. Settings screen in whatsapp is also a separate activity and not a fragment. Side bar is shown where we have fragments. In settings, more settings will be opened from the screen in future therefore having a separate activity is better for this.

Assadbintahir commented 7 years ago

After the discussion with sojharo, I have converted the settings screen into a fragment. So that sidebar is accessible and UX is consistent throughout the application

Code for this issue has been completed. I will open the pull request for it.

jekram commented 7 years ago

Thanks