search

Cloudkibo / Android

0 stars 0 forks source link

Unblock feature is not working as it works on whatsapp #556

Open Assadbintahir opened 7 years ago

Assadbintahir commented 7 years ago

On Whatsapp, when we block someone, chat with that person remains in chatlist. If we try to send send message to blocked contact, it shows dialog to unblock it first.

While on KiboChat, when we block someone, chat with that person is removed from chatlist + contact list and we are removed from the chatlist + contact list of targeted person. So we can't even access old chat.

If we unblock someone now, s/he will appear on our chatlist. But we'll still be removed from target person device. He won't get any of our messages UNLESS targeted person re sync by clicking refresh contacts. which should not be the case.

Steps:

1- send some messages to device 2 from device 1. 2- Block device 2 from device 1. 3- device 2 will be removed from chatlist and contact list of device 1 (can't access earlier chat, different from whatsapp) device 1 will be removed from chatlist and contact list of device 2 (can't access earlier chat, different from whatsapp) 4- Now unblock device 2 from the blocked list of device 1. 5- device 2 will appear in chatlist and contact list of device 1. 6- Send message from device 1 to device 2 (device 2 is not blocked now) 7- Message won't be received at device 2. 8- Unless we refresh contacts on device 2.

jekram commented 7 years ago

@sumairasaeed FYI

@sojharo

sojharo commented 7 years ago

@Assadbintahir please discuss this with me before you start work on this.

sojharo commented 7 years ago

We have discussed this issue and need to break it into following sub tasks:

  1. When we block someone, he should not go invisible from chatlist and contacts

  2. When we unblock someone, he doesn't get messages until he refresh his address book

  3. Blocked contact should not allow to send message and shows the dialogue box to unblock the contact first.

  4. When I am blocked by someone, I should normally send message but server will not send it.

Assadbintahir commented 7 years ago

I have completed part 1 and 3 for this issue.

This issue is still in progress.

Assadbintahir commented 7 years ago

I have worked on point 2. It is under construction. I am currently facing some errors. I will continue my work on this and will try to finish it in a day or two.

jekram commented 7 years ago

thanks for the update

Assadbintahir commented 7 years ago

I am unable to solve point 2. I have discussed with sojharo. We'll sit on friday to solve all aspects of unblock feature.

However, I have completed code for point 4.

jekram commented 7 years ago

Ok. Thanks for the update