Cloudkibo / Android

0 stars 0 forks source link

Broadcast should only go to person who has broadcaster as contact #580

Closed sojharo closed 7 years ago

sojharo commented 7 years ago

While reviewing whatsapp, I found this restriction on broadcast feature. The broadcast can only go to those contacts who have added the broadcaster to their address book. This would save from spamming. I would think how we can do this work. We might do server side work for this.

sojharo commented 7 years ago

screenshot_2017-04-25-12-55-48

sojharo commented 7 years ago

@sumairasaeed we will do design discussion on this task before we carry on this.

sumairasaeed commented 7 years ago

Yes ok.

sojharo commented 7 years ago

After thinking on design I found the easiest way to put this restriction and it would be done on server side and not client side. Server will check if recipient in broadcast list has broadcaster in contact or not. Thus server will itself reject message for that person.

screen shot 2017-04-28 at 11 28 18 am

We would do little change on server side where address book is synced for first time. In this, We should not make a two way friendship if contact in address book of a user is found on cloudkibo, we should make only one way friendsihp.

screen shot 2017-04-28 at 11 30 15 am
sojharo commented 7 years ago

I will do the server side work and track it in this task. Then we can close it.

sojharo commented 7 years ago

I have completed the server side work in this and pushed the code. Please reinstall the application in order for this to take effect.

jekram commented 7 years ago

Thanks