search

Cloudkibo / CloudKibo

CloudKibo
0 stars 0 forks source link

Push notification for 1-1 call signalling #484

Open sumairasaeed opened 7 years ago

sumairasaeed commented 7 years ago

This is required for iOS task https://github.com/Cloudkibo/iOS/issues/247 . On iOS, socket gets disconnected when application is in background so server finds that user is "offline" and call signalling does not start. We need to have a push notification to let user know that there is a call so he can go to application and signalling gets started. I have discussed this with @sojharo and he has suggested to open this server side work

sojharo commented 7 years ago

I am going to pick this task for today as sumaira future task are dependent on this. I would open android side task as well for this change. We would start signalling using push notification. I would do the design first after discussing with sumaira about iOS requirements.

sojharo commented 7 years ago

I had a detailed discussion and testing with sumaira on this. She needs to do some research and testing in order to understand more about how iOS receives call when app is in background. In order to do further testing, I added the push notification in the code which sumaira can test and then she will let me know if that push notification is enough for her iOS work. I would then mark this issue resolved.

For this, sumaira is working on this task: https://github.com/Cloudkibo/iOS/issues/247

jekram commented 7 years ago

@sojharo Is this needed for Android also or just iOS? Please describe how is not an issue for Android?

sojharo commented 7 years ago

No, it is not needed by android as there we have the freedom to open screen of incoming call even if app is not running. It doesn't depend on type of push notification coming. However, in iOS the push notification payload needs special keys in it in order to invoke incoming call screen and play ring tone. Sumaira is reading more on it and trying to understand how whatsapp is doing it on iOS. I think it is much better that server is independent of whether client is android or iOS. But there were clear differences on how whatsapp call was coming on android and how it was coming on previous version of iOS. However, the new version of iOS is showing the UI.