Cloudkibo / CloudKibo

CloudKibo
0 stars 0 forks source link

File Transfer not working between two chrome #65

Closed jekram closed 9 years ago

jekram commented 9 years ago

File Transfer not working between two chromes. It just sits there.

sojharo commented 9 years ago

File Transfer can only be tested on two computers. I had tested it on two computers. It is because only one instance of chrome can take hold of file system of the computer at one time.

On Thu, Apr 16, 2015 at 11:47 AM, Cloudkibo notifications@github.com wrote:

File Transfer not working between two chromes. It just sits there.

— Reply to this email directly or view it on GitHub https://github.com/Cloudkibo/CloudKibo/issues/65.

Regards,

Sojharo

jekram commented 9 years ago

I am testing on two computers

image

sojharo commented 9 years ago

Let me look into it. I just tested the file transfer inside the cloudkibo chat. Let me look into livehelp page.

On Thu, Apr 16, 2015 at 11:52 AM, Cloudkibo notifications@github.com wrote:

I am testing on two computers

[image: image] https://cloud.githubusercontent.com/assets/5336012/7175533/6932a2c8-e3ca-11e4-83e6-2c64325a61c7.png

— Reply to this email directly or view it on GitHub https://github.com/Cloudkibo/CloudKibo/issues/65#issuecomment-93658916.

Regards,

Sojharo

jekram commented 9 years ago

During our status meeting file transfer did not worked.

sojharo commented 9 years ago

This has been fixed in both live help and meeting. I have pushed the code. Now, I need to check it on two separate computers. After this, I would mark it resolved.

By looking at the code, I realized there still some areas in code which needs to be moved to KiboRTC library. This will make the code clean. This is the code cleaning work and we can do this as a low priority.

jekram commented 9 years ago

Sojharo ASAK:

Is this done also?

"By looking at the code, I realized there still some areas in code which needs to be moved to KiboRTC library. This will make the code clean. This is the code cleaning work and we can do this as a low priority."

sojharo commented 9 years ago

Yes, functionality wise the error was resolved. I just realized that there is a lot of space of code improvement. Not by efficiency, but by modularity.

On Tue, May 12, 2015 at 11:30 PM, Cloudkibo notifications@github.com wrote:

Sojharo ASAK:

Is this done also?

"By looking at the code, I realized there still some areas in code which needs to be moved to KiboRTC library. This will make the code clean. This is the code cleaning work and we can do this as a low priority."

— Reply to this email directly or view it on GitHub https://github.com/Cloudkibo/CloudKibo/issues/65#issuecomment-101376823.

Regards,

Sojharo

jekram commented 9 years ago

Should we close this? Keep it open? Open a new low priority item?

sojharo commented 9 years ago

Yes, we can close it and open a low priority item. On May 13, 2015 2:06 AM, "Cloudkibo" notifications@github.com wrote:

Should we close this? Keep it open? Open a new low priority item?

— Reply to this email directly or view it on GitHub https://github.com/Cloudkibo/CloudKibo/issues/65#issuecomment-101420838.

jekram commented 9 years ago

Sojharo:

I am going to close this issue, please open a new issue as per the discussion above

Jawaid

sojharo commented 9 years ago

Opened this new item #75