search

Cloudkibo / KiboAPI

0 stars 0 forks source link

Server Side auth middleware and token generation work #4

Closed sojharo closed 5 years ago

sojharo commented 5 years ago

This is for writing some authe middlewares and token generators. Please refer to the document carefully to understand it.

https://docs.google.com/document/d/1s055cdCOirIQxXDYIaNNuVzJQcKPbKJmBMVG1B0h8aU/edit#

jekram commented 5 years ago

What is the next step here? It is blocking other task

bjafri5 commented 5 years ago

This is complete. @AnishaChhatwani please test

AnishaChhatwani commented 5 years ago

There is some unused code here. @bjafri5 please remove that

bjafri5 commented 5 years ago

This is complete. @AnishaChhatwani please test

sojharo commented 5 years ago

@bjafri5 please get it tested today. use postman.

sojharo commented 5 years ago

@bjafri5 any updates?

saniasiddiqui commented 5 years ago

I have made the changes in auth middle ware to make API calls to KiboEngage using app_id and app_secret. Tested this using Postman: image

@sojharo please review the changes done. The change has also been done in KiboEngage and Accounts authentication files. Above Merge Request shows the changed files.

saniasiddiqui commented 5 years ago

The work for this task included changes in Accounts, KiboChat and KiboEngage Repositories. I have tested the work on local setup. However it can be tested on kiboapi.cloudkibo.com once all the changes from kibochat / kiboengage and accounts repository are in production. We can test this on Monday after the production merge.

jekram commented 5 years ago

@saniasiddiqui Did @sojharo not do the production merge on Friday?

saniasiddiqui commented 5 years ago

The code had to be reviewed here. Friday merge did not include this work.

AnishaChhatwani commented 5 years ago

tested