Cloudkibo / KiboPush

0 stars 1 forks source link

For some accounts Subscriber graph is incorrect on Dashboard #10171

Closed arveenkumar55 closed 3 years ago

arveenkumar55 commented 4 years ago

Describe the bug I looked Subscriber graph on Dashboard it is incorrect for some Accounts. On x-axis, it is not clear what direction we are going. It start with year 2019, then next is 2018, then next is 2020, then next is 2019 again, then next is 2019 and then 2020

To Reproduce Steps to reproduce the behavior:

  1. Go to Dashboard
  2. See subscriber graph
  3. See error

Expected behavior Subscriber Graph should display correctly data

Front End or Backend End issue? Frontend How was the issue found the automated test or manual test? Manual

When was this issues last working? For some Account it is showing wrong Data graph

Screenshots

Sojharo Account: sojharo@gmail.com The graph is incorrect

Screenshot 2020-10-16 at 3 29 07 PM

For my and Anisha Account account it is fine

Screenshot from 2020-10-16 15-43-39

Screenshot from 2020-10-16 15-54-56

Paper Trail logs There were no Paper trails logs here

Browser logs There were no browser logs here

Sentry Links and Screenshots There were no sentry links here

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

arveenkumar55 commented 4 years ago

I looked there is no milestone fit this issue.

saniasiddiqui commented 4 years ago

@arveenkumar55 please test on staging.

saniasiddiqui commented 4 years ago

Identify what broke the code? This was happening because the query from which the graph data was being fetched was not sorting the results on the basis of date time.

Identify the commit and developer who is responsible for that change. (Issue number, pull request) Work initially done under this commit by Anisha https://github.com/Cloudkibo/KiboChat/commit/945c57b0dac390cf33983a67ac2f589beea3c44c#diff-3e7dcaf79174c57769550c060ef0304666fff09c9af2ac1ba95a4a0584537528

What is the way that we can ensure that this code doesn’t break again? Added sort in the query

Explain the reason before you put fix. The graph data should be sorted on the bases of year, month and then date.

Is this part covered in the test plan? No (added: TC0106 on dashboard tab) https://docs.google.com/spreadsheets/d/1tHANMLEVJ8gKd6Z_ZCJpwxNJyBKXJ-qFrr9PBIt6wZU/edit#gid=471201810

arveenkumar55 commented 4 years ago

working fine on staging.

arveenkumar55 commented 4 years ago

It is working for messenger Platform. same problem is also occuring on sms/whatsapp platforms. @saniasiddiqui please look

arveenkumar55 commented 4 years ago

working fine on staging

arveenkumar55 commented 4 years ago

working fine on production