search

Cloudkibo / KiboPush

0 stars 1 forks source link

URGENT Production Broken: Cannot send Card #3758

Closed jekram closed 6 years ago

jekram commented 6 years ago

URGENT Production Broken: Cannot send Card

I am sending a card and it is saying Sard mush have an image. The image is already loaded.

image

This was the image that was loaded.

neil patel blog

jekram commented 6 years ago

THis is completely broken ever the Image is broken

Assadbintahir commented 6 years ago

Reason of the Bug: The validation on the client and server side was checking a wrong field named 'image_url' which was not even part of the payload. Because of this, the app was giving error of missing image.

client Payload: screenshot from 2018-07-16 03-43-23

Solution: Instead of 'image_url', "fileurl.url" was required to be validated. This same thing was happening in both client and server side broadcast validation.

Whoever made the changes in validation / payload (for the server), did not test the code even for once.

Work on this is completed

jekram commented 6 years ago

@sojharo @ImranBinShoukat Let's move this to Staging and then production ASAP.

@Assadbintahir Thanks for fixing it

sojharo commented 6 years ago

Assigning @arveenkumar55 for testing.