Logic to add / remove link

[ImranBinShoukat]

In this we will write a logic to add / remove link between blocks. Link should also be removed by pressing the delete button from the keyboard.

For further details please refer to the design document: https://docs.google.com/document/d/19O_vLsq6aKuvboYc7Ir7zcn3BMJBN1S1CT0oieYELXw/edit?pli=1#

[bjafri5]

Logic for removing links has been completed. The Ui/logic for adding links remains.

[bjafri5]

@ImranBinShoukat and I looked into this issue. We are having trouble creating a link at a dynamic position in the UI (it is not being placed at specific button positions). Imran has opened an issue in the library repository (https://github.com/MrBlenny/react-flow-chart/issues/69). We are currently waiting for a response. We will look more into this tomorrow.

[bjafri5]

@ImranBinShoukat and I looked into this today. We tried the solution given on the issue Imran created, however that didn't work. We then tried coming up with a solution of our own, however we are running into issues regarding rendering. We will further look into this tomorrow. Apart from this issue, all other flow builder coding issues are complete.

[bjafri5]

@ImranBinShoukat and I spent a lot of time on this yesterday. We have implemented the logic for adding and removing a link. There are still some issues with the UI not rendering properly, along with the link ports not being displayed at their correct position. We will try to finish this by today

[bjafri5]

@ImranBinShoukat and I worked on this today. We made good progress and the linking and unlinking logic is pretty much complete, however there is still an issue with rendering. When we try to add a linked component from within the flow builder, it doesn't render the link properly. We will try to fix this on Monday

[bjafri5]

@ImranBinShoukat and I worked on this today and managed to get the positioning to work properly for the links:

There are still some rendering issues remaining which will be fixed by tomorrow IA

[bjafri5]

Major issues with linking have been fixed. There are some issues remaining regarding the linking UI with card/gallery which we will try to fix today.

[bjafri5]

Issues regarding validation were fixed. When a link is removed from a button, it will highlight that button as red indicating that there is no action attached to the button.

There are still issues regarding card/gallery link rendering which we will look into today

[ImranBinShoukat]

Here, we had to commit out the code to position ports on button because it was causing issues. So, we committed out the code to show ports at the right side of message block. It's not ideal but its working fine. We can work on showing ports on button in v2 or later.

[jekram]

@ImranBinShoukat Pleas show a screenshot who it looks now and how this will be fixed in v2

[jekram]

@ImranBinShoukat what is the staus here?

[ImranBinShoukat]

This is how it looks. Right now ports (dots) are shown at the edge of message block. Ideally, it should have been placed at the button.

[jekram]

Ok. Thanks. Continue to fix this issue.

[jekram]

Is this work complete? what else is pending on it