search

Cloudkibo / KiboPush

0 stars 1 forks source link

Push Notifications for Live Chat #8666

Open AnishaChhatwani opened 4 years ago

AnishaChhatwani commented 4 years ago

This task is to write logic to show notifications on mobile whenever a subscriber messages

arveenkumar55 commented 4 years ago

Task Update: Today I have fixed some UI issues after upgrade expo SDK also fixed this issue Notification remains even after viewing the message. but there is another issue which I am facing when the app is close and if we get a notification and click on the notification it is not redirecting to chat screen due to NotificationResponseReceivedListener is not called. This is not our code bug it is expo SDK38.0.0 bug. https://github.com/expo/expo/issues/6943 this is already opened a ticket and I have commented. Now waiting for a response.

arveenkumar55 commented 4 years ago

I got some answers from the expo community from still I am facing same problem. I have commented again. https://github.com/expo/expo/issues/9866

jekram commented 4 years ago

@sojharo @arveenkumar55 @AnishaChhatwani

This is not rocket science - There are millions of apps that are getting notification. What is the solution?

What is the implication if notification is not working on the application?

Why we are not discussing this in the status meeting

arveenkumar55 commented 4 years ago

I have create a document with screenshot https://docs.google.com/document/d/1qmDuVBiWeinHfU5ASuXg2_LyLszmNyvHjrR4lxCV5vs/edit?usp=sharing will discuss in meeting.

Faizan20 commented 4 years ago

I did manual testing today and found out that. I am not getting any push notifications @arveenkumar55 please look into this issue.

arveenkumar55 commented 4 years ago

@Faizan20 please test now locally

Faizan20 commented 4 years ago

I have tested locally I am recieving push notifications now.

jekram commented 3 years ago

@arveenkumar55 What is the status of this task? Is the code on staging or production? The last status if from 20 days ago?

@sojharo Please review

sojharo commented 3 years ago

I will review this with @arveenkumar55 today.

arveenkumar55 commented 3 years ago

There are three scenarios in which a user can get push Notifications on Mobile.

For Android:

  1. When an App is in the foreground(open) and when the user clicks on the notification it is redirecting to the chat screen (expected)

  2. When an App is in the background and when the user clicks on the notification it is redirecting to the chat screen (expected)

  3. When an App is in the close and when the user clicks on the notification it is redirecting to the Livechat Session screen (Not expected)

For IOS:

  1. When an App is in the foreground(open) and when the user clicks on the notification it is redirecting to the Livechat Session screen (Not expected).

  2. When an App is in the background and when the user clicks on the notification it is redirecting to the Livechat Session screen (Not expected).

  3. When an App is in the close and when the user clicks on the notification it is redirecting to the Livechat Session screen (Not expected)

In Every case when a user clicks on a notification it should redirect to the chat screen, not the Livechat Session screen. It is because of NotificationResponseReceivedListener is not called. This is not our code bug it is expo SDK38.0.0 bug. https://github.com/expo/expo/issues/9866

This code is in Production.

jekram commented 3 years ago

@sojharo @arveenkumar55 I am confused and lost. What is the next here if any?

arveenkumar55 commented 3 years ago

The work is complete from our side but we are getting errors from the expo. In Every case when a user clicks on a notification it should redirect to the chat screen, not the Livechat Session screen. It is because of NotificationResponseReceivedListener is not called. This is not our code bug it is the expo SDK38.0.0 bug. expo/expo#9866

sojharo commented 3 years ago

Assigning this to @AnishaChhatwani

Please see if the issue got resolved or not. Else try to find a workaround for this.