Cloudkibo / KiboPush

0 stars 1 forks source link

Video link module is not working for some youtube URLS #9303

Open arveenkumar55 opened 4 years ago

arveenkumar55 commented 4 years ago

Describe the bug When i try to add youtube URLs in video link some are working and some aren't working. Working URLS https://www.youtube.com/watch?v=jLgb3CVVTRw NOt Working URLs https://www.youtube.com/watch?v=T94PHkuydcw https://www.youtube.com/watch?v=tionpZAVPd4

To Reproduce Steps to reproduce the behavior:

  1. Go to broadcast
  2. Click on the video link
  3. Enter URLs above
  4. See error

Expected behavior Video link modules should work for all youtube URLS.

Front End or Backend End issue? Backend How was the issue found the automated test or manual test? Manual

When was this issues last working?

It is working for some URLS Screenshots Screenshot from 2020-07-22 16-41-15

Paper Trail logs There were no paper trails logs here

Browser logs test

Sentry Links and Screenshots There were no sentry links here

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

saniasiddiqui commented 4 years ago

i was getting the following error in library, as mentioned in the repository issue: https://github.com/przemyslawpluta/node-youtube-dl/issues/311

upgrade of the library has helped to overcome the error. now i am able to process both youtube files mentioned in the issue. Assigning @arveenkumar55 to test

arveenkumar55 commented 4 years ago

@saniasiddiqui sometime i am getting this issue. @saniasiddiqui please look Screenshot from 2020-07-24 17-14-12

saniasiddiqui commented 4 years ago

The issue was that error response from backend is not being handled at front end. So any time the download/upload to facebook fails UI shows no valid error response. I have fixed the issues and submitted pull request.

saniasiddiqui commented 4 years ago

@arveenkumar55 please test image

image

arveenkumar55 commented 4 years ago

working fine on staging

jekram commented 4 years ago

@saniasiddiqui what is the status?

arveenkumar55 commented 4 years ago

@saniasiddiqui still sometime it is not working. @saniasiddiqui please look Screenshot from 2020-07-30 11-22-33