Cloudkibo / KiboPush

0 stars 1 forks source link

Messenger Chatbot: We should not allow leading and trailing spaces and tabs in triggers. #9736

Closed Faizan20 closed 4 years ago

Faizan20 commented 4 years ago

Describe the bug When I added a trigger using leading spaces or trailing spaces That trigger is not firing from messenger. Because Messenger not allow leading and trailing spaces and tabs.

To Reproduce Steps to reproduce the behavior: "1. On welcome block screen of the bot

  1. Go to triggers and add a trigger word with space i.e, 'hello ',
  2. save the bot.
  3. from messenger that trigger will not call
  4. see Error

Expected behavior We should not allow leading and trailing spaces and tabs in triggers so that triggers call successfully

Front End or Backend End issue? Front End

How was the issue found the automated test or manual test? Manual

When was this issues last working? New Issue

Screenshots

Screenshot from 2020-09-08 13-55-01 Screenshot from 2020-09-08 13-55-23

Paper Trail logs None Browser logs None Sentry Links and Screenshots None

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Faizan20 commented 4 years ago

This use case is never tested before there was no use case of it in the test plan also i have added it in the test plan now.

https://docs.google.com/spreadsheets/d/1lJ-dZOSxjuLS7MJJBFrWcZkkjVvpIGWV3MwWss0UT5E/edit#gid=1508891791 Row: 1547

arveenkumar55 commented 4 years ago

@Faizan20 please test on staging

Faizan20 commented 4 years ago

Tested Working fine on staging

arveenkumar55 commented 4 years ago

@Faizan20 please test on production

Faizan20 commented 4 years ago

Working fine on production as well