Cloudkibo / KiboPush

0 stars 1 forks source link

Messenger Chatbot: validation on attachment type #9751

Closed Faizan20 closed 4 years ago

Faizan20 commented 4 years ago

Describe the bug While uploading attachement from computer i found out that it is accepting .exe file but on messenger it is not delivering that file

To Reproduce Steps to reproduce the behavior:

  1. On welcome block screen of the bot
  2. upload an .exe file,
  3. now trigger that block from messenger.
  4. see Error

Expected behavior It should validate the files properly which can be delivered on messenger. Front End or Backend End issue? Front End

How was the issue found the automated test or manual test? manual testing

When was this issues last working?

Screenshots Screenshot from 2020-09-08 15-01-54

Screenshot from 2020-09-08 15-06-25

Paper Trail logs Put Papertrail logs here test

Browser logs None Sentry Links and Screenshots None

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Faizan20 commented 4 years ago

The upload file work has been done in this commit https://github.com/Cloudkibo/KiboChat/pull/661/commits/1928d56486c311643ae0862b9c11b66f9d4bbbff and the issue was https://github.com/Cloudkibo/KiboPush/issues/9462 I think something is missing here for the validation of file type.

arveenkumar55 commented 4 years ago

@Faizan20 please test on staging

Faizan20 commented 4 years ago

Working fine on staging

arveenkumar55 commented 4 years ago

@Faizan20 please test on production

Faizan20 commented 4 years ago

working fine on production