Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

If we are not on App screen, call is not received #247

Open sumairasaeed opened 8 years ago

sumairasaeed commented 8 years ago

If we go to iOS Home screen and our Kibo App is still running, if somebody calls, call is not received.

jekram commented 8 years ago

@sumairasaeed

We need to design and test these uses cases. Instead of calling task complete and then opening bugs.

We are working backward. Can you share the design document of 1-1 call?

sumairasaeed commented 8 years ago

Here is flowchart of 1-1 call i had designed: https://cloud.githubusercontent.com/assets/10936743/15692360/6b2f061c-27a7-11e6-9a59-a0822d854c3a.png

On Tue, Jun 14, 2016 at 11:24 PM, Cloudkibo notifications@github.com wrote:

@sumairasaeed https://github.com/sumairasaeed

We need to design and test these uses cases. Instead of calling task complete and then opening bugs.

We are working backward. Can you share the design document of 1-1 call?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/247#issuecomment-225971525, or mute the thread https://github.com/notifications/unsubscribe/AKbhp8uBE4hcCvuEqTdn6ZinwxtHcApQks5qLvHFgaJpZM4I1frO .

jekram commented 8 years ago

When was this flowchart created? Please stop sending me old flow charts

this flowchart is either old or completely illogical.

we do not have login anymore.

jekram commented 8 years ago

First define all the use case and show me how this will work.

sumairasaeed commented 8 years ago

Here is a design document for kibo 1-1 call. https://drive.google.com/open?id=0B3lStktK2xjyT2JnaXpxUlhaTnM . I have tried to cover maximum use cases. Please let me know if i missed something

On Wed, Jun 15, 2016 at 1:26 AM, Cloudkibo notifications@github.com wrote:

First define all the use case and show me how this will work.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/247#issuecomment-226005249, or mute the thread https://github.com/notifications/unsubscribe/AKbhp39-C56faZkvexyWRnU5nvLO23fVks5qLw5ZgaJpZM4I1frO .

jekram commented 8 years ago

@sumairasaeed Thanks

Please review this with @sojharo

@sojharo & @sumairasaeed when you are in agreement then send the final copy to me for review.

sojharo commented 8 years ago

Ok sir

sumairasaeed commented 8 years ago

@sojharo : Previous link was PDF. Here is the link for ppt slide so you can edit and make changes if required https://docs.google.com/a/cloudkibo.com/presentation/d/1O2ULS1tySV02dB9VGk_NzD7DwUZQxuS66tiNZJr2bN4/edit?usp=sharing

sojharo commented 8 years ago

I have seen it and diagrams are complicated. I will sit with sumaira and revise it. I will do it after doing android tasks. So, it will take me sometime. Flow-wise it is correct but very difficult to comprehend.

sojharo commented 8 years ago

Sumaira and I have discussed it and reviewed it. We can discuss it in meeting now.

sumairasaeed commented 8 years ago

I worked on showing notification for incomming call when application is not active. I tested it once with sojharo. Notification appeared on app icon but it does not disappear when we click on it. I need to do more testing to understand where the bug is and what is happening. Here is screenshot: image

jekram commented 8 years ago

@sojharo @sumairasaeed

If we revised the document then please send me revised document? Let me know

sumairasaeed commented 8 years ago

Yes sir. here is revised document https://docs.google.com/presentation/d/1O2ULS1tySV02dB9VGk_NzD7DwUZQxuS66tiNZJr2bN4/edit#slide=id.p4

On Thu, Jun 16, 2016 at 10:10 PM, Cloudkibo notifications@github.com wrote:

@sojharo https://github.com/sojharo @sumairasaeed https://github.com/sumairasaeed

If we revised the document then please send me revised document? Let me know

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/247#issuecomment-226550561, or mute the thread https://github.com/notifications/unsubscribe/AKbhpyT8PZcEvSj2-yPrDCzRwURqE8Mtks5qMYOAgaJpZM4I1frO .

sumairasaeed commented 8 years ago

Steps: Me and sir both were on app screen I went into background sir called me I didnot get any notification After around 5 minutes, my phone got locked and after i unlocked it, i saw call notifications. Here is screenshot: image

jekram commented 8 years ago

@sumairasaeed

On an another task it said iOS to IOs call is working?

This one says it does not?

What is the status of this?

What is working?

What is not working?

What is the effort required to close this task?

sumairasaeed commented 8 years ago

Yes sir. 1-1 call is working fine when both users are online on application. This is when application is in background sir. We discussed we will need GCM for handling this case

jekram commented 8 years ago

No, 1-1 Call is NOT working.

We make a misleading statement when we say 1-1 Call is working. When all use cases are not covered it is not working. It will fail 90+% of the time without GCM. We have 90*% failure and we still call the overall task working.

sumairasaeed commented 7 years ago

We need to have push notification for 1-1 call for iOS. I discussed this with @sojharo and he suggested to open a task on server side as it will need server side work https://github.com/Cloudkibo/CloudKibo/issues/484

jekram commented 7 years ago

why it took 6 months to realize this?