Closed sumairasaeed closed 7 years ago
I explored and read up on it yesterday. I found that in order to mute/unmute notifications, some changes will be required in server payload also. I have opened task for this on server side https://github.com/Cloudkibo/CloudKibo/issues/472 .
I have completed the client side code for this. Also designed the UI for setting "mute" for a specific group. I will need to add small code to notify server after server side task Cloudkibo/CloudKibo#472 is done.
This is blocked due to server side task https://github.com/Cloudkibo/CloudKibo/issues/472
why do we need server side code to this functionality?
This is because, iOS shows notification by reading payload format. We have a field of "sound" in payload which tells that a sound to be played. If this field is missing, it will be mute. As payload is coming from server so we need server side work for this functionality.
On Mon, Dec 26, 2016 at 1:24 PM, Cloudkibo notifications@github.com wrote:
why do we need server side code to this functionality?
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/362#issuecomment-269182741, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhp5SWZKhWyRQMao0ISwxbir22ghZ4ks5rL3m5gaJpZM4KXf9s .
I understand that server is sending the notification. I am asking why client cannot ignore the notification based on local settings?
Sir, on iOS we donot have this control on client side for how to display the notification. I will look into it again to confirm I am not missing anything.
On Mon, Dec 26, 2016 at 1:29 PM, Cloudkibo notifications@github.com wrote:
I understand that server is sending the notification. I am asking why client cannot ignore the notification based on local settings?
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/362#issuecomment-269183323, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhp7lKXAxufNxhPLXE67smWVyplmX5ks5rL3rggaJpZM4KXf9s .
Only work on this based on the overall priority
I have removed the "blocked". However, I do not understand why we need work on the server side. This is a client side work and tell me why we cannot make that chat or group to be quite?
Sir, on iOS alert , sound fields are displayed by mobile by reading payload from server. We can change overall setting of app by not registering app to play 'sound' . But we have no control to mute certain notifications. It depends on payload received from server. If server has sent 'sound' field in payload then it will play else it would be silent
Worked on this yesterday. Coded the logic to Mute group notifications. I found from logs that on server, group is marked as mute but even then payload field contains 'alert' and 'sound' field so group notification is not being mute. The server endpoint returns success but is not working correctly. Here are the logs screenshot:
I will again test this endpoint Cloudkibo/CloudKibo#472 with @sojharo
This task has been completed now. Mute and unmute group feature is working fine.
Thanks
On the client side, the group member should have option to mute or unmute the group notifications. This is in whatsapp and saves us from too much notifications and alerts when lots of people are speaking in a group at once. User can turn it on or off.