search

Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

Replace cashing library from HanekeSwift to Kingfisher #458

Closed jekram closed 7 years ago

jekram commented 7 years ago

image

Replace cashing library from HanekeSwift to Kingfisher

https://github.com/Haneke/HanekeSwift https://github.com/onevcat/Kingfisher

Required for Task #461

jekram commented 7 years ago

Update?

jekram commented 7 years ago

Is this not including the library? Or you have to do some coding change?

sumairasaeed commented 7 years ago

This is to replace the library and to do the coding changes. We will use Kingfisher library functions for image caching and image loading instead of HanekeSwift.

On Mon, Feb 6, 2017 at 12:55 PM, Cloudkibo notifications@github.com wrote:

Is this not including the library? Or you have to do some coding change?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/458#issuecomment-277608101, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhp7eMy2fxsxFiwqFERmOjdaeE3zCwks5rZtIAgaJpZM4LVUdg .

jekram commented 7 years ago

How many lines of coding changes are required here?

Do a separate commit for this

sumairasaeed commented 7 years ago

I have completed work on this. Did 2 separate commits for this issue as requested.

jekram commented 7 years ago

Thanks

jekram commented 7 years ago

when can we push this to marker place? what are the other dependencies?