search

Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

Avatars are shown blank #488

Closed sumairasaeed closed 7 years ago

sumairasaeed commented 7 years ago

Avatars are shown blank and images not loaded. Looking into it.

jekram commented 7 years ago

for UI issues it is better to attach a screenshot

sumairasaeed commented 7 years ago

Here is screenshot:

screen shot 2017-02-13 at 10 42 38 am
jekram commented 7 years ago

I see Avatar is missing. I do not understand when you say images are missing?

sumairasaeed commented 7 years ago

I meant same that images of avatars are not loaded.

jekram commented 7 years ago

Then this is a bug but not high priority.

sumairasaeed commented 7 years ago

Worked and debugged on this. Was stuck on retrieving avatars by converting asset resource to format required by library. Looking more into this

jekram commented 7 years ago

I do not understand this. I am assuming this was working before and it is a conversion issue. WE should not try to enhance the logic.We should get it working and then change later.

sumairasaeed commented 7 years ago

We replaced Haneke image caching library with Kingfisher. The issue is that it requires different format of parameters which were required by Haneke library. Worked on this. I was able to cache and retrieve default avatar images from cache when avatar is not available. Here is screenshot:

screen shot 2017-02-17 at 6 00 44 pm

Remaining work on this is to retrieve avatars available and show.

jekram commented 7 years ago

Should we not assume that different library would have Thier own unique parameters? However did we tested using the new library?

jekram commented 7 years ago

what is the update here?

jekram commented 7 years ago

I want update on Github to be updated when the task is assigned and you are working on it.

Explain it here

sumairasaeed commented 7 years ago

Using Kingfisher library, was able to show default avatars. The issue is in converting real avatars fetched from Contacts book to a format acceptable by library. Searched more and found that a submodule of Alamofire library called 'AlamofireImage' accepts the format we have and it can fulfil the purpose and solve our issue. Trying to integrate AlamofireImage into our app. It is having some conflicts. This is in progress.

jekram commented 7 years ago

what formats Kingfisher accepts and what format we have when we fetch from Contact book?

same question for Alamofireimage?

sumairasaeed commented 7 years ago

Kingfisher accepts url and we have Data format when we fetch from Contact book. AlamofireImage accepts both url and data format. I worked more today and and now successfully integrated AlamofireImage into our app. Now working to make required changes to show avatars.

sumairasaeed commented 7 years ago

This task has been completed now. Avatars are shown correctly.

jekram commented 7 years ago

Thanks