Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

File share Logic for sharing Location #524

Closed sumairasaeed closed 7 years ago

sumairasaeed commented 7 years ago

Here we will implement Logic for sharing Location as file attachment as watsapp does.

jekram commented 7 years ago

Update the design document and test cases as part of this task

sumairasaeed commented 7 years ago

Coding is completed. Tested from iOS to iOS and between Android and iOS. Will mark it as resolved once i am done with updating documentation and test matrix

jekram commented 7 years ago

Thanks for the update

sumairasaeed commented 7 years ago

Updated document and test matrix as part of this task. We can please close this now

sumairasaeed commented 7 years ago

App crashing when sharing location

sumairasaeed commented 7 years ago

This has been fixed now

jekram commented 7 years ago

What was the issue and how did we fixed it?

sumairasaeed commented 7 years ago

The issue was that location manager delegate was getting deallocated and thus location coordinates were returning null. Corrected it by setting delegate in didLoad method.

On Thu, Mar 23, 2017 at 9:34 AM, Cloudkibo notifications@github.com wrote:

What was the issue and how did we fixed it?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/524#issuecomment-288614932, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhp5dBrVIEErEa4-OcPWAwInksYypAks5rofZQgaJpZM4MIOGH .