search

Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

File share Logic for sharing Video as File attachment #528

Closed sumairasaeed closed 7 years ago

sumairasaeed commented 7 years ago

Here we will implement logic for sharing videos as file attachment

jekram commented 7 years ago

Update the design document and test cases as part of this task

sumairasaeed commented 7 years ago

Worked on this. Was able to capture the details/metadata of video selected to be shared. Remaining part is to upload it on server

jekram commented 7 years ago

Why we are not completing task and moving on a next task before completing them?

sumairasaeed commented 7 years ago

Worked on this. There was an error. Image sharing and video sharing delegate methods had a conflict. I found that as i worked on this video sharing task, our previous file transfer of images and documents got broken. Looked into it and found the bug. Previously the delegate method "didFinishPickingImage" was called when image was selected and our all logic of image sharing was there. When we implemented video sharing, previous delegate method was not called and it called new delegate method "didFinishPickingMediaWithInfo" both for sharing images and videos. Image and document sharing was not working as its delegate method was not triggered. I have fixed it and now it is working again.

On video sharing, i have completed work for uploading video. Video is now successfully uploaded on server. Remaining is implementing video downloading part. It is in progress

jekram commented 7 years ago

Thanks for the update.

sumairasaeed commented 7 years ago

Video download logic has been completed. There is some error in saving and writing video in app sandbox. Looking into it.

jekram commented 7 years ago

Ok

sumairasaeed commented 7 years ago

I have finally resolved the issue with 528. Video is now correctly downloaded, saved and played on UI. Will mark this as resolved after some more testing

sumairasaeed commented 7 years ago

This is done

jekram commented 7 years ago

Please attache screen shots here of your test? Have you also tested between iOS and Android?

sumairasaeed commented 7 years ago

Attached screenshots on 529. tried testing with sojharo but he said video part is not yet merged. so will test with him once he has merged in evening

jekram commented 7 years ago

This was asked two days ago. When I ask a question I expect a response in a timely manner.

sojharo commented 7 years ago

I am ready to test it. Just give me 15 minutes. So that I finish the work on pull request by asad. After this I would test it with her.

sumairasaeed commented 7 years ago

Testing with sojharo. Videos are received from android to iOS . Also from iOS to iOS. But not received by android if sent from iOS. We both are debugging to figure out if issue is on android side or iOS side.

sojharo commented 7 years ago

It looks like file type issue to me. As video is also working between two androids. However, the video type of iOS is video/quicktime or mov, and android can't play this type of video. I think by installing quick time player app for android might fix this.

jekram commented 7 years ago

Please use Whatapp as the model and we need to support what is is supporting

sojharo commented 7 years ago

After some testing, we have found that it is working on iOS to android too. The problem was file is too big and takes time to download. I was closing the app from android studio without waiting longer.

The correction for this should be to use some indicator to let user know how much file is downloaded. I would open task for this on android side so that we can track if file attachment is completely downloaded or not yet.

jekram commented 7 years ago

Thanks