search

Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

File share UI work for sharing video as file attachment #529

Closed sumairasaeed closed 7 years ago

sumairasaeed commented 7 years ago

Here we will do UI work needed for sharing Videos as file attachment

sumairasaeed commented 7 years ago

Exploring and reading up on it how video can be shown and played on UI of iOS. Will update more here.

sumairasaeed commented 7 years ago

Worked on this. Now it shows videos on UI when sharing files from where user can select the video to be shared.

sumairasaeed commented 7 years ago

Completed work on this. Understood implementation video component for playing videos. Created a sample application with the component and was able to play a sample video. Also created that component in our application.

jekram commented 7 years ago

So should we mark it resolved? If the work is complete.

jekram commented 7 years ago

I am assuming that design document and test matrix have been kept current. Correct?

Please send me screen shot of the test

sumairasaeed commented 7 years ago

Yes sir. design document is updated. Test matrix updated till last week. Will do more testing this week and update. Emailing you testing screenshots

sumairasaeed commented 7 years ago

Tested after completing #528 . Video is correctly shown if one video is shared. If more than one video shared, then it shows black area and video is not played. Reopening and looking into it

jekram commented 7 years ago

Did we not tested multiple videos before?

sumairasaeed commented 7 years ago

This has been fixed now. In this, we created and tested UI component for attaching and playing video inside player. Tested it by attaching video with an element. Video plays as full screen when clicked. Same as in watsapp.

jekram commented 7 years ago

You did not answered my previous question?

Do you even read them or just chose to not answer them.

sumairasaeed commented 7 years ago

Sorry. It was missed. No sir. Was not able to test iOS to Android. Here are screenshots for test results

screen shot 2017-02-27 at 3 50 50 pm

![Uploading Screen Shot 2017-02-27 at 3.51.25 PM.png…]() ![Uploading Screen Shot 2017-02-27 at 3.51.54 PM.png…]() ![Uploading Screen Shot 2017-02-27 at 3.52.09 PM.png…]() ![Uploading Screen Shot 2017-02-27 at 3.52.24 PM.png…]() ![Uploading Screen Shot 2017-02-27 at 3.53.01 PM.png…]() ![Uploading Screen Shot 2017-02-27 at 12.19.57 PM.png…]() ![Uploading Screen Shot 2017-02-27 at 12.26.32 PM.png…]() ![Uploading Screen Shot 2017-02-27 at 12.27.51 PM.png…]() ![Uploading Screen Shot 2017-02-27 at 12.30.27 PM.png…]() ![Uploading Screen Shot 2017-02-27 at 12.30.40 PM.png…]()

jekram commented 7 years ago

why we would not test with Android? when Android was getting developed there was no iOS so they could not test with iOS.

Would it not be logical to test with Android to make sure it is working? or you think we should do it later and reopen closed issues?

sumairasaeed commented 7 years ago

Thats right that we should test with Android also. I have Android 4.4 on my phone and KiboChat app does not run on it. I would carry out tests by borrowing from sojharo or dayem tomorrow in office IA whoever is available.

jekram commented 7 years ago

There are multiple ways to test. They do not need to be in the office. You can slack or email them. I would be happy also to test.

jekram commented 7 years ago

What is the status here? My expectations is that when I put comment that I get an response in a timely manner.

sumairasaeed commented 7 years ago

Video part on android is not merged. sojharo will merge it in a while. will test then

jekram commented 7 years ago

Ok

sumairasaeed commented 7 years ago

Tested. video sharing is working fine between android and iOS

jekram commented 7 years ago

Thanks for the update