(File attachment) Sender should be able to see what contact was sent.

Cloudkibo / iOS

iOS Code

0 stars 0 forks source link

(File attachment) Sender should be able to see what contact was sent. #537

Closed sumairasaeed closed 7 years ago

sumairasaeed commented 7 years ago

When sharing contact, contact should be clickable and display details as whatsapp:

jekram commented 7 years ago

why now? do we not understand what we had to do in the first place.

sumairasaeed commented 7 years ago

Worked on this. It now displays details when we tap on contact. Need to add "Create Contact" button

sumairasaeed commented 7 years ago

Also WatsApp has buttons for "Invite to WatsApp" and "Message" when contact is shared. Will also implement these as part of this task:

sumairasaeed commented 7 years ago

I have worked and completed the UI work for this but this will need some server side work to code the functionality. I have discussed this with @sojharo and opened required task on server https://github.com/Cloudkibo/CloudKibo/issues/507

jekram commented 7 years ago

@sumairasaeed @sojharo I do not understand this.

We bring all the contacts on the initial install. When a new contact is a added to address book do we not add them into KiboChat ?
When somebody was not using KiboChat and start using it I thought it is reflected in KiboChat address book.
If the the above #1 and # 2 are true then you ask is redundant.

sumairasaeed commented 7 years ago

We bring all the contacts on the initial install. When a new contact is a added to address book do we not add them into KiboChat ?

Ans: Yes sir we do.

When somebody was not using KiboChat and start using it I thought it is reflected in KiboChat address book.

Ans: Currently it is not reflected.

If the the above #1 and # 2 are true then you ask is redundant.

Ans: This is the case when we receive a contact shared by other user. That contact can be in our addressbook already and cannot be. That contact could be the one registered on KiboChat and could be the one not using KiboChat. We have to display buttons accordingly. But for that we must get this information from server whether the contact is registered on kibochat or not. If not, we will display option to "Invite to KiboChat".

jekram commented 7 years ago

@sumairasaeed

Thanks for the update.

If we not doing #2 then we should do #2 and open a bug. If #1 & #2 are done then we do not need to fix this.

sojharo commented 7 years ago

I have seen the server side task. The one way we were doing no 2 was if I get message from somebody who is shown not on cloudkibo in my address book then we should update him on the address book to be shown as on cloudkibo. From server side, I can send a push notification when a user joins cloudkibo.

sumairasaeed commented 7 years ago

This has been completed now