Closed sumairasaeed closed 7 years ago
@sojharo Do you handle this in Android?
Dayem had written code to handle this. He was doing it in a different way. i.e. if person A is in my address book and he is not on kibochat. Later, when he joins kibochat and sends me a message. At that time I would update my address book to show person A as contact on cloudkibo. The other way is to get notification from server that person A has joined, this one can be done by using same dayem's logic. This time the logic would be called on notification from server. On Android, the other way is not done. It could be easily done in two lines of code as the update part is already done by @dayemsiddiqui . I would send the push notification from server and handle this work in server side issue. Therefore, I don't need same task to be opened for android as logic is already there by @dayemsiddiqui .
Work on this has been completed
Is the testing complete
If testing is pending then "Work on this has been completed" is not accurate.
Tested this with a new user number. Push is not received from server when new user joins cloudkibo later. Debugging and looking into it if there is some issue in registering tagname which listens for the push for new user.
Debugged lot but couldnot catch any fault in client side logic. Tested on android with sojharo and it didnot work on android as well. Logic was rechecked on server and found a typo error on server-side logic. Also Azure hub didnot allow special character "_" in tagname. We were previously using "new_user" so it was then changed to "newuser" . Did Similar change on client side code and it worked fine. We can close this now.
Thanks
When somebody was not using KiboChat and start using it , it should be reflected in KiboChat address book