search

Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

UI work for Attaching URL in chat #579

Closed sumairasaeed closed 7 years ago

sumairasaeed commented 7 years ago

Here we will do UI work as whatsapp for Attaching URL in chat.

screen shot 2017-04-04 at 4 13 36 pm screen shot 2017-04-04 at 4 13 55 pm
jekram commented 7 years ago

Why are we opening new task now? How did we tested the logic?

jekram commented 7 years ago

What is the update here? If a task on toady's list then we need to have update. There is no exception.

sumairasaeed commented 7 years ago

Had written the update yesternight. May be it failed due to internet issue.

Tested logic by fetching metadata of URL. Tested and found a new usecase in whatsapp so UI was complicated so opened another task.

Spent lot of time on this. Was able to show URL as whatsapp in chat. Also URL is correctly shared and linked to webpage. It opens up the URL webpage when tapped. Was stuck in showing realtime popup with metadata details. Found two of libraries. Was stuck in integrating and there were errors. https://github.com/marty-suzuki/URLEmbeddedView/tree/feature/swift3.

screen shot 2017-04-06 at 2 33 29 am screen shot 2017-04-06 at 2 33 37 am
jekram commented 7 years ago

What is the next step to close this?

sumairasaeed commented 7 years ago

Worked more on this today. Was able to create custom UI for URLs and display metadata of URL (UI#1) but there are still errors in it. It takes time to load and scroll is not smooth. Kindly let me know if we can keep UI simple in v1 and work to make it detailed in v2 as I need to work and try more to fix this. This will take one day more effort to get completed.

image

jekram commented 7 years ago

This has been 5 days now. When should I expect it to complete?

sumairasaeed commented 7 years ago

working on it. will wrap it up by today.

sumairasaeed commented 7 years ago

Spent lot of time on this. Meta data of URL is loaded correctly now. There are still some issues in cell allignments on UI. It would be better if we can defer it as its taking long and is not very critical and there are other issues which needs to be fixed. There is no major usage of url metadata. It is just for display.

Main functionality is to share URL and it should be clickable and open webpage. This whole functionality is working fine.

jekram commented 7 years ago

You should work on multiple tasks anyway. So this task should not stop you on working other task. I would like to understand what is the next step in solving this issue and how long it would take?

jekram commented 7 years ago

what is the update here?

sumairasaeed commented 7 years ago

Next step here is to try Auto Layout. It would take a day. Did not work on this as was working on other High priority task.

sumairasaeed commented 7 years ago

This has been fixed now as we implemented auto layout. image

jekram commented 7 years ago

Thanks. Please push this to Test Flight and confirm it.

Why I am not getting notification on Test Flight?

sumairasaeed commented 7 years ago

Yes sir. I will push it now. Sir, Is the latest 0.1306(0.11) version not visible on your test flight? I will check again about notifications

On Wed, Apr 26, 2017 at 10:44 AM, Cloudkibo notifications@github.com wrote:

Thanks. Please push this to Test Flight and confirm it.

Why I am not getting notification on Test Flight?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/579#issuecomment-297243964, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhpyZn0Q6MoWSyyWl4rGLfg4jhcYPHks5rztm1gaJpZM4My4ZH .