search

Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

Search in Favourites Tab #595

Open sumairasaeed opened 7 years ago

sumairasaeed commented 7 years ago

Implement Search feature in favourites tab

jekram commented 7 years ago

Urgent: I do not understand this. I thought we already have implemented search feature. Please explain what are we doing here?

sumairasaeed commented 7 years ago

We have Search feature to search chat messages in chats tab and search all contacts from contacts tab. This is to implement search in favourites tab

On Thu, Apr 13, 2017 at 11:02 AM, Cloudkibo notifications@github.com wrote:

Urgent: I do not understand this. I thought we already have implemented search feature. Please explain what are we doing here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/595#issuecomment-293790336, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhp2Ab2-3iRePdjym5oeZpH-fYdSSIks5rvbp2gaJpZM4M7d_H .

jekram commented 7 years ago

So essentially the same logic. Correct. Any reason we did not implemented this in the first place?

jekram commented 7 years ago

@sumairasaeed Please respond to my question

sumairasaeed commented 7 years ago

Few days back I was looking for a contact in "Favourites" tab and feel the need that there should be a search bar. Even I was wondering why i didnot find and added it previously. I have found the answer. We didnot implement it because Whatsapp didnot have it in 'Favourites' tab. Here is screenshot of older version of whatsapp. (No search bar in favourites):

screen shot 2017-04-15 at 12 09 20 pm

We were following whatsapp and whatsapp ddidnot have this "Search feature" in "Favourites" tab. I opened this task because i feel the need if list is large in 'Favourites' tab. Kindly let me know if we need to have this 'Search' feature in 'Favourites' or not?

Note: Whatsapp has completely removed "Contacts" and "Favourites" tab in its new version of app.

jekram commented 7 years ago

Thanks for the update. It make sense.

Please send me what WhatsApp has changed. My iPhone is not working.

sumairasaeed commented 7 years ago

Here is screenshot of whatsapp's changed tabs: image

jekram commented 7 years ago

How do you find contacts now?

sumairasaeed commented 7 years ago

They have removed tab for 'Contacts' . Now we go to chat and press 'new chat' icon , there it shows whole contacts list. You can select any and start chatting from there.

sumairasaeed commented 7 years ago

Whatsapp new version has removed 'Favourites' tab. Please suggest do we need to keep it and work to add 'Search bar' or should we remove it?

jekram commented 7 years ago

I need to get my iPhone and play with it.

Have you already started on it? If what % is complete.

What is the function of Status?

jekram commented 7 years ago

what are they showing in Status?

sumairasaeed commented 7 years ago

They show Day status. We can share photo/video status to show whats going on in our day. It will disappear within 24 hours. We have a task for its design here https://github.com/Cloudkibo/iOS/issues/596

sumairasaeed commented 7 years ago

No. We have not started working on it

sumairasaeed commented 7 years ago

As we have added day Status feature tab in place of favourites tab as watsapp, we can close this task now as it has become invalid.