Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

Create String files for internationalisation #604

Closed sumairasaeed closed 7 years ago

sumairasaeed commented 7 years ago

We will create strings files to store and retrieve all of the strings which are coded and used within the app for each language.

sumairasaeed commented 7 years ago

Worked on this. Generic logic of capturing strings from within code and making changes is around 60% complete. Will work more on this. Next will have to translate all those strings like dictionary in a file.

jekram commented 7 years ago

I am confused between this task and Internationalising storyboard #606

Is this task #604 content creation or logic?

sumairasaeed commented 7 years ago

Responded to question on #606. Storyboard contains all the UI interfaces of our application. This task is content creation for labels pre-defined on storyboard.

This task #604 includes both logic and content creation. In #604 , we need to change code so the data will then be displayed according to locale instead of having fixed value. In #604, we will also have to create content in all 5 languages so our code logic will read from there.

jekram commented 7 years ago

Thanks. If this task is both content creation and logic. Then what is task #606 content creation is for? How many places we will have content creation?

sumairasaeed commented 7 years ago

Sir we have content creation as part of two tasks. 1- #606 : For translating text defined on UI screen when creating it. 2- #604 :For text which is dynamic and programatically coded within application w.r.t required logic and flow

jekram commented 7 years ago

What is an example of dynamic content?

sumairasaeed commented 7 years ago

Yes sir. The content which is dependent on some logic and is not always displayed on screen. Content displayed on alerts for example "Internet connectivity is required to exit this group".

sumairasaeed commented 7 years ago

Completed logic work for this and completed content creation work for french. Here is an example screenshots:

screen shot 2017-04-17 at 6 02 41 pm

Working for German now

sumairasaeed commented 7 years ago

Had completed work for German language required for this issue.

jekram commented 7 years ago

when these task will get done?

sumairasaeed commented 7 years ago

Sir there are more than 100 dynamic strings which need translation in each language. Will try best to wrap this task by today.

On Tue, Apr 18, 2017 at 10:46 AM, Cloudkibo notifications@github.com wrote:

when these task will get done?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/604#issuecomment-294692329, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhpwBEHJ76L7NiLI4FtQr4itygXah5ks5rxE4ugaJpZM4M9HOY .

jekram commented 7 years ago

I hope you are not converting these by hand. Google would translate it for you. :-)

sumairasaeed commented 7 years ago

Sir, i am using google translator but then have to copy/paste each manually in a dictionary format required by localizedString file.

sumairasaeed commented 7 years ago

Completed work for Spanish.

jekram commented 7 years ago

I thought we were go wrap this yesterday? What is left?

sumairasaeed commented 7 years ago

Arabic and Urdu were left. This task has been completed now.

On Wed, Apr 19, 2017 at 10:52 AM, Cloudkibo notifications@github.com wrote:

I thought we were go wrap this yesterday? What is left?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/604#issuecomment-295106835, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhp3w-QXSVgivk4JPuS7ebo2--DPW4ks5rxaEkgaJpZM4M9HOY .

jekram commented 7 years ago

Thanks for getting this done. Can you please attache a screen shot?

jekram commented 7 years ago

Has the code published on Test Flight? I have not seen any notification lately about test Flight.

When was the last release and date we published on Test Flight?

sumairasaeed commented 7 years ago

Right sir, did not push from some time as there were bugs and app was not stable. Once tried pushing but there was some issue. Leaving for home. Will push it tonight once I am back home IA.

Here is screenshot for Arabic: image

jekram commented 7 years ago

Mark it done after you have pushed the code to TEST FLIGHT

sumairasaeed commented 7 years ago

Acknowledged. Pushed

jekram commented 7 years ago

BTW The Arabic looks great :

jekram commented 7 years ago

👍