search

Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

Use AutoLayout and remove explicit UI constraints #608

Closed sumairasaeed closed 7 years ago

sumairasaeed commented 7 years ago

We will have to convert whole app to "Auto Layout" so it will get adjusted when change in font length for each language

jekram commented 7 years ago

Note: The description should be more detailed.

Please explain this more fully. What is the problem? What is the implication if we do nothing? What is the Fix? Is this because of Language or we should do this regardless.

sumairasaeed commented 7 years ago

Sir, the problem is that different languages will have different string lengths and layouts (e.g. Urdu and Aravic goes right to left). Currently UI constraints are set according to English language. A word can be longer in French so needs adjustment. Here is current screenshot where the french word for "Broadcast list" was bigger so didnot fit:

screen shot 2017-04-15 at 12 17 22 pm

We will have to work to make Auto constraints so they will get adjusted according to requirements of language. In this task I also intended to cover the part of making layout changes left-right to right-left for urdu and arabic.

jekram commented 7 years ago

Thanks. Auto constraints should have implemented​ regardless on international language as a best practice. This is what I read.

sumairasaeed commented 7 years ago

Read and understood implementation. Applied Auto Constraint on a sample one-page app successfully. Started implementing into our application. This is in progress

jekram commented 7 years ago

Send me Apple or other write up on it?

sumairasaeed commented 7 years ago

https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/AutolayoutPG/ProgrammaticallyCreatingConstraints.html

Other is https://makeapppie.com/2014/07/26/the-swift-swift-tutorial-how-to-use-uiviews-with-auto-layout-programmatically

jekram commented 7 years ago

Should we have not used this in the first place long time ago?

sumairasaeed commented 7 years ago

Yes Sir. We had purchased a template which had some already-made UI screens for Chat app which we customized and utilised further. Template did not have Auto Layout enabled.

On Sat, Apr 22, 2017 at 10:43 AM, Cloudkibo notifications@github.com wrote:

Should we have not used this in the first place long time ago?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/608#issuecomment-296349862, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhp3lgchVCzY2XSutEMzLre7ZXhwF3ks5ryZN5gaJpZM4M9HeB .

jekram commented 7 years ago

@sumairasaeed You need to own the accountability. Had you informed me then we could have purchased another template. "Template did not have Auto Layout enabled" is a lame excuse.

Are we not enabling the same template or we are getting rid of the template?

sumairasaeed commented 7 years ago

We are enabling Auto layout on template. Worked and enabled it on Chats tab and it now Auto flips and adjusts for arabic (Right to left) Here is screenshot: image

sumairasaeed commented 7 years ago

Also, it now adjusts font according to language. Example in french, previously text was larger so did not fit. After auto layout on Chats tab, it adjusts as shown:

image

sumairasaeed commented 7 years ago

Was stuck on setting layouts for conversations screen as there are multiple types of cells for message,image,document,audio,video .. Need to look more into it. Currently Conversations UI is broken. Worked on more screens of Contacts,Favourites, also on some other Screens for Settings tab, screens shown at the time of installation. Here are few screenshots: image image

sumairasaeed commented 7 years ago

Auto layout implemented on all screens except conversations screen. Conversation screen is bit complicated. was stuck on it. Working on it. Here are some of screenshots after auto layout. Text adjusted and direction is right to left for arabic: image

jekram commented 7 years ago

Thanks. What is the ETA to get this done.

It is taking super long

sumairasaeed commented 7 years ago

This will be completed by today.

On Mon, Apr 24, 2017 at 11:02 PM, Cloudkibo notifications@github.com wrote:

Thanks. What is the ETA to get this done.

It is taking super long

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/608#issuecomment-296772634, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhp-AcBSFLBoDSjneXuJaPjW-Uj2Ybks5rzOPIgaJpZM4M9HeB .

sumairasaeed commented 7 years ago

Worked on 1-1 chat UI screen . Completed work for chats. There is some issue in adjusting URL cell. Will update more on this. Here is screenshot for chats auto layout: image

jekram commented 7 years ago

What is the ETA?

sumairasaeed commented 7 years ago

Completed work on this last night. Tested Sender's chat cells for chat,image,document,video,audio,contact etc. Due to internet issues was unable to test receiving end cells. Will mark it resolved after some testing on receiving side.

jekram commented 7 years ago

Thanks. What Internet issue? At home or @work?

sumairasaeed commented 7 years ago

At home sir. Worked on remaining part last night at home.

On Wed, Apr 26, 2017 at 10:42 AM, Cloudkibo notifications@github.com wrote:

Thanks. What Internet issue? At home or @work https://github.com/work?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/608#issuecomment-297243718, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhp_FvbaFTpJIYYgwSaSNNvfOqcBtPks5rztlKgaJpZM4M9HeB .

sumairasaeed commented 7 years ago

Receiving side testing was done and bugs were fixed. This has been completed

jekram commented 7 years ago

Thanks