Cloudkibo / iOS

iOS Code
0 stars 0 forks source link

Broadcast should only go to person who has broadcaster as contact #609

Closed sumairasaeed closed 7 years ago

sumairasaeed commented 7 years ago

The broadcast can only go to those contacts who have added the broadcaster to their address book. This might need server side work as mentioned by @sojharo on android issue https://github.com/Cloudkibo/Android/issues/580 . Will discuss design with sojharo and will then implement it.

sumairasaeed commented 7 years ago

This task is invalid now as this logic has been implemented and handled on server side. We can close this please

sumairasaeed commented 7 years ago

@sojharo just recalled that there is a change required on client side. He has created a separate endpoint. So this needs client side work

jekram commented 7 years ago

Ok

sojharo commented 7 years ago

Yes, please use the documentation in the following link:

https://github.com/Cloudkibo/CloudKibo/issues/509#issuecomment-297989691

sumairasaeed commented 7 years ago

Thanks

On Mon, May 1, 2017 at 11:53 PM, Sojharo notifications@github.com wrote:

Yes, please use the documentation in the following link:

Cloudkibo/CloudKibo#509 (comment) https://github.com/Cloudkibo/CloudKibo/issues/509#issuecomment-297989691

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cloudkibo/iOS/issues/609#issuecomment-298401508, or mute the thread https://github.com/notifications/unsubscribe-auth/AKbhpyTwZGn_xi5IVY6RK_sKD89aPmPxks5r1ioZgaJpZM4NHQoa .

sumairasaeed commented 7 years ago

This task has been completed.

jekram commented 7 years ago

Please push this to Test Flight