This Pull Request addresses some minor issues uncovered when preparing for re-running the Initial Setup procedure as called for in Issue #10.
Changes
Now that a variables.tf file exists, the gcp_project_suffix variable, currently defined in the gcp.tf file, should be moved to the variables.tf file, since that is the widely adopted convention in Terraform projects and modules.
The README.md file still contained a paragraph describing the replaced terraform-cloud.sh script, including the command to launch that script. Since the information was already duplicated into the paragraph explaining the now combined initial-setup.sh script, this unnecessary paragraph and code block were simply removed.
Since the current GCP Project ID suffix will need to change (Projects take 30 days to fully delete in GCP), the gcp_project_suffix variable value as well as the table in the README.md file were updated to the new value.
This Pull Request addresses some minor issues uncovered when preparing for re-running the Initial Setup procedure as called for in Issue #10.
Changes
Now that a variables.tf file exists, the gcp_project_suffix variable, currently defined in the gcp.tf file, should be moved to the variables.tf file, since that is the widely adopted convention in Terraform projects and modules.
The README.md file still contained a paragraph describing the replaced terraform-cloud.sh script, including the command to launch that script. Since the information was already duplicated into the paragraph explaining the now combined initial-setup.sh script, this unnecessary paragraph and code block were simply removed.
Since the current GCP Project ID suffix will need to change (Projects take 30 days to fully delete in GCP), the gcp_project_suffix variable value as well as the table in the README.md file were updated to the new value.