Cloudslab / cloudsim

CloudSim: A Framework For Modeling And Simulation Of Cloud Computing Infrastructures And Services
http://www.cloudbus.org/cloudsim/
816 stars 491 forks source link

Problem in Consts.java #147

Open alitariqnet opened 3 years ago

alitariqnet commented 3 years ago

// ================== Time constants ================== /* One minute time in seconds. / public static final int MINUTE = 60; / One hour time in seconds. / public static final int HOUR = 60 MINUTE; / One day time in seconds. / public static final int DAY = 24 HOUR; /* One week time in seconds. / public static final int WEEK = 24 * HOUR;

Above lines are written in Consts.java in Cloudsim 5.0 pre-release Do you think that the last line should be, /* One week time in seconds. / public static final int WEEK = 7 * DAY; ?

lak-sh-mi commented 3 years ago

Looking at the logic if it is to represent seconds as stated in comments week = 7 * day

This bug may not be obvious of the constant week is not used in the implementations of the tool. Did we know it the usage if week?

On Mon, Feb 22, 2021, 12:02 AM alitariqnet notifications@github.com wrote:

// ================== Time constants ================== /** One minute time in seconds.

*/ public static final int MINUTE = 60; /** One hour time in seconds.

/ public static final int HOUR = 60 MINUTE; /** One day time in seconds.

/ public static final int DAY = 24 HOUR; /* One week time in seconds. / public static final int WEEK = 24 * HOUR;

Above lines are written in Consts.java in Cloudsim 5.0 pre-release Do you think that the last line should be, /* One week time in seconds. / public static final int WEEK = 7 * DAY; ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Cloudslab/cloudsim/issues/147, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANMB32ZMFEODTGRYOHAJ77LTAFGUDANCNFSM4X7HU4CA .