Closed jan-herout closed 8 months ago
The fix assumes that even with custom delimiters, comments are always defined as {* comment *}
.
I would suggest adding the capability to change comment markers in future major version, perhaps as a new option.
Code suggested in the fix could perhaps stay the same. I do not know. It is up to your discretion.
Regards,
Jan
PS. sorry for typos in code comments.
Very good catch! I agree this should get a major release fix as soon as possible where WithDelims() forces you to specify your custom comment markers, too. For now, I like #188 as a fix and will release a bugfix after I merged it, but I'll leave this issue open until after the "real" fix. Thank you!
After tinkering with Jet using custom delimiters I was able to reproduce the following problem directly on Jet test suite.
testData/custom_delimiters.jet
{* comment *}[[ . ]]
Might it be that this is the source of the problem? See below... It seems that methow
WithDelims
should accept full delimiter set to allow for correct parsing of comments.