search

Cloufield / gwaslab

A Python package for handling and visualizing GWAS summary statistics. https://cloufield.github.io/gwaslab/
GNU General Public License v3.0
160 stars 25 forks source link

Naming convention mismatches fixed #72

Closed soumickmj closed 11 months ago

soumickmj commented 11 months ago

A recent change in the naming convention for the arguments for saving the plots (saveargs -> save_args), made the library inconsistent. 9 files save_args, while 5 files saveargs (4 of them were markdowns). The only plotting script that was still using saveargs was the miami plot - also causing it to fail as the save_figure call (line 698) was using the old saveargs, while the new save_figure function is expecting save_args.

Morever, src/gwaslab/viz_plot_mqqplot.py file was trying to send "qq_scatter_args", but in src/gwaslab/viz_plot_qqplot.py, it was called "qq_scatter_kwargs". Keeping with the naming convention of using "args" in other places in the caller file, I have modifed qq_scatter_kwargs to qq_scatter_args - to work properly now.

Cloufield commented 11 months ago

Thanks for fixing the naming bug! Actually, I am working on a major upgrade of the package, including unifying the very messy naming system as you pointed out.

soumickmj commented 11 months ago

Lovely! Thanks!