search

CloverHealth / pytest-pgsql

Clean PostgreSQL Databases for Your Tests
http://pytest-pgsql.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
65 stars 4 forks source link

[BUG] `make setup` doesn't work #2

Closed dargueta closed 6 years ago

dargueta commented 6 years ago

make setup doesn't work if you try to run the tests afterwards. This is because only one version of Python is installed. You need all supported versions.

To reproduce:

  1. Clone the repo
  2. Run make setup
  3. Run tox

If make setup doesn't crash (see incompatibility notice) then you'll see a bunch of tox setup errors and then this at the end of the test run:

ERROR:   py33: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.3: b"pyenv: python3.3: command not found\\n\\nThe `python3.3\' command exists in these Python versions:\\n  3.3.6\\n\\n"',)
ERROR:   py34: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.4: b"pyenv: python3.4: command not found\\n\\nThe `python3.4\' command exists in these Python versions:\\n  3.4.7\\n\\n"',)
ERROR:   py35: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.5: b"pyenv: python3.5: command not found\\n\\nThe `python3.5\' command exists in these Python versions:\\n  3.5.4\\n\\n"',)
ERROR:   py36: commands failed
dargueta commented 6 years ago

@wesleykendall FYI

wesleykendall commented 6 years ago

@dargueta lgtm. I just enabled circle to do builds on forks. Can you push an empty commit or something to try to trigger a build? Not seeing a way to manually do it

wesleykendall commented 6 years ago

@dargueta please unpin all of those requirements you just changed. If any app that uses this library upgrades sqlalchemy, freezegun, or testing.postgresql outside the range, builds will fail and block deployments until we do a new deploy here. It's unnecessary to pin those and it's a risk if others can't deploy security upgrades quickly (or any updates for that matter). We should only pin when we are certain this library is incompatible with those versions

dargueta commented 6 years ago

@wesleykendall done! I can't merge it though.

wesleykendall commented 6 years ago

@dargueta just released as 1.0.3