search

CloverHealth / pytest-pgsql

Clean PostgreSQL Databases for Your Tests
http://pytest-pgsql.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
65 stars 4 forks source link

[BUG] Remove silently ignored --pg-driver CLI option. #3

Closed dargueta closed 6 years ago

dargueta commented 6 years ago

Version 1.0.2 removed the ability to specify your Postgres driver but didn't remove the --pg-driver CLI option. This resulted in a bug where passing --pg-driver to pytest wouldn't change the driver. Since there's no way to work around this, we have to remove the CLI option.

@wesleykendall

wesleykendall commented 6 years ago

@dargueta lgtm, just had a question about pylint

wesleykendall commented 6 years ago

@dargueta let me know and I'll merge if you have no other additions

dargueta commented 6 years ago

let me know

Uh... do you mean this? https://github.com/CloverHealth/pytest-pgsql/pull/3#discussion_r160490805

I'll merge if you have no other additions

Nah, I'm done. Good to go on my end!

wesleykendall commented 6 years ago

@dargueta do you want me to do an api break so that it will be on 2.0? I am fine with keeping it on 1.0 since this feature wasn't being used by anyone yet. I'd kinda like to keep the api breaks only when we truly break the API and release a big change. Let me know what you think

dargueta commented 6 years ago

Er... I already put api-break in the first commit message. Will pbr ignore it if you change the merge commit message?

Anyway, I'll leave it up to you.

wesleykendall commented 6 years ago

@dargueta only the message in the squashed commit will be used by PBR. I'll ignore doing an API break for this