Clowud / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

'pwd' path is hardcoded #477

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
This breaks 'winetricks' for distributions with non-FHS layouts, such as NixOS. 
Provided patch fixes the issue. I don't know, but *maybe* this would cause 
breakage on OS X (I don't have one to test); they should have 'pwd' in PATH too 
though, shouldn't they?

Original issue reported on code.google.com by nikoa...@gmail.com on 16 Feb 2015 at 9:43

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for reporting, fixed by 
https://code.google.com/p/winetricks/source/detail?r=72516176a4ea6927356275d6829
be208c9c7c66b

it works fine on OSX, note that pwd is called in two other places without a 
specified path.

Original comment by austinenglish@gmail.com on 16 Feb 2015 at 10:28

GoogleCodeExporter commented 8 years ago
/bin/pwd was specified to avoid getting the shell's builtin pwd, which gives a
different answer sometimes (if pwd was reached via a symlink, say).

It's possible this change breaks some users.

Original comment by daniel.r...@gmail.com on 16 Feb 2015 at 10:44

GoogleCodeExporter commented 8 years ago
Thanks! I'll update NixOS package repository. If there are breakages and you 
revert or change this, please make a note here! Personally I don't think 
shell's pwd would break things.

Original comment by nikoa...@gmail.com on 17 Feb 2015 at 2:39

GoogleCodeExporter commented 8 years ago
Can you please consider this patch too? As with the previous one, we use just 
'perl' in some places, so this shouldn't hurt. This would allow to remove the 
last NixOS-specific patch.

Original comment by nikoa...@gmail.com on 17 Feb 2015 at 10:59

Attachments:

GoogleCodeExporter commented 8 years ago
Please file that as a separate issue.

Original comment by austinenglish@gmail.com on 17 Feb 2015 at 6:32