search

ClubEspritLibre / the-Gnu-Distro

A Gnu Distro WebApp
3 stars 15 forks source link

getting the usbIsPresent and the popen issues fixed #24

Open modamod opened 11 years ago

modamod commented 11 years ago

First test the changes cos am lacking distros at the moment and dont forget to update the issues list

rednaks commented 11 years ago

Thank you for your patch ! I know that it's your first contribution, so here are some advices for the next time : This patch is related to the issue number #20 and #23 and you are trying to solve them in a single commit. This is not the right way to do we deal with each issue separately as far as they are not depending on each others. You can solve one issue with multiple commits. The second remark is that you didn't mention the issue number on your commit message. actually we do for example : git commit -m " Bug Fix #23 : Replacing deprecated functions"

let me first test this patch, then I'll keep the pull request open so that you'll be able to fix this, you have just to commit and push to your repo branch and the commits will be queued to this pull request.