search

ClubInfoInsaT / application-amicale

Application Android et IOS pour l'amicale des élèves
Other
9 stars 4 forks source link

[WIP] - Notification settings #69

Open gerald-lbn opened 1 year ago

gerald-lbn commented 1 year ago

Solves #67.

Untested on iOS

The code works but the linter complains about syntax here

https://github.com/ClubInfoInsaT/application-amicale/blob/49acb69cb7f49bc5f0eb7c362d15350b086096f9/src/screens/Other/Settings/SettingsScreen.tsx#L325-L333

By changing the syntax like this,

Linking.sendIntent( 
   'android.settings.APP_NOTIFICATION_SETTINGS', 
   [ 
     { 
       key: 'android.provider.extra.APP_PACKAGE', 
       value: 'fr.amicaleinsat.application', 
     }, 
   ] 
 );

there's no error message from the linter but the settings page doesn't open anymore.

ignyx commented 1 year ago

I'll have a look at the ios behavior when I get back to Tls. This will probably require some "platform is android"-like conditional.