CluedIn-io / CluedIn.Enricher.VatLayer

0 stars 0 forks source link

Missing invalid data response handling logic #5

Open kevinobee opened 5 years ago

kevinobee commented 5 years ago

https://github.com/CluedIn-io/Enricher.VatLayer/blob/ae711603e9664cc54e650a1cdb6b33e6db571697/src/VatLayerExternalSearchProvider.cs#L109

Missing else block to handle successful calls to client.ExecuteTaskAsync<VatLayerResponse>(request) that return invalid data.

Failure paths in public methods should either throw an exception or return an error result. In both cases the failure condition should be logged.