search

CluedIn-io / CluedIn.Enricher.VatLayer

0 stars 0 forks source link

VAT Cleaner Test project targets framework '.NETCoreApp,Version=v2.1' #8

Closed kevinobee closed 4 years ago

kevinobee commented 4 years ago

The ExternalSearch.Providers.VatLayer project incorrectly targets version 2.1 of the NetCoreApp framework. The project should be targeting the net452 framework.

Steps to Reproduce

  1. git clone repository
  2. change directory into cloned repository folder
  3. run dotnet build

Expected Results:

0 warnings, 0 errors from the compiler.

Actual Results

C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(1653,5): warning NU1702: ProjectReference 'C:\source\CluedIn-io\Enricher\Enricher.VatLayer\src\ExternalSearch.Providers.VatLayer.csproj' was resolved using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.1'. 
This project may not be fully compatible with your project. [C:\source\CluedIn-io\Enricher\Enricher.VatLayer\VATCleanerTests\VATCleanerTests.csproj]
kevinobee commented 4 years ago

Fixed in branch https://github.com/CluedIn-io/Enricher.VatLayer/tree/bugfix/Xunit-Test-Conversion

kevinobee commented 4 years ago

Fixed by PR https://github.com/CluedIn-io/Enricher.VatLayer/pull/10