search

Clueless-Community / collegeAPI

An API that helps you to fetch colleges and their details.
GNU General Public License v3.0
58 stars 61 forks source link

Add an endpoint to fetch the overall ranked colleges by NIRF. #126

Closed nikhil25803 closed 2 years ago

nikhil25803 commented 2 years ago

Description

Notes

Screenshots

No response

Additional information

No response

srini047 commented 2 years ago

Hi team, I would like to work on this issue.

nikhil25803 commented 2 years ago

Sure @srini047, go ahead.

nikhil25803 commented 2 years ago

Hey @srini047, any updates?

srini047 commented 2 years ago

Hey, @nikhil25803 sorry for the inconvenience. I currently have my internals scheduled which ends tomorrow. I will update the progress tomorrow.

srini047 commented 2 years ago

@nikhil25803 I have a small doubt.

While I was trying to add a /all/nirf endpoint I came to know that it already exists in the code.

https://github.com/Clueless-Community/collegeAPI/blob/main/main.py#L86-L95

Is my understanding correct? If not correct I would love to hear it.

nikhil25803 commented 2 years ago

Hey @srini047, change that endpoint to /all. And name your as /all/nirf

srini047 commented 2 years ago

Hey, @nikhil25803 shocked to see that the endpoint /all/nirf already exists in the main.py file.

nikhil25803 commented 2 years ago

Hey, @nikhil25803 shocked to see that the endpoint /all/nirf already exists in the main.py file.

I quotes earlier... Change that endpoint to /all and add your new endpoint as /all/nirf

srini047 commented 2 years ago

Hey, @nikhil25803 shocked to see that the endpoint /all/nirf already exists in the main.py file.

I quotes earlier... Change that endpoint to /all and add your new endpoint as /all/nirf

/all endpoint too already exists.

nikhil25803 commented 2 years ago

Yes, @srini047 👀 Thanks for letting me know and extremely sorry for the inconvinience.