search

Clueless-Community / collegeAPI

An API that helps you to fetch colleges and their details.
GNU General Public License v3.0
56 stars 60 forks source link

add a college name in data/allEngineeringColleges.json #146

Closed SanskritiGupta05 closed 1 year ago

SanskritiGupta05 commented 1 year ago

What would you like to share?

I'd like to add a college name in allEngineeringColleges.json file in the data Folder. please assign this issue to me.

Additional information

No response

nikhil25803 commented 1 year ago

Hey @SanskritiGupta05, we do not add colleges that are not listed by NIRF, also can't accept this because according to the PR/MR policy of Hactoberfest, repos that encourage simplistic PR/MRS (like adding a name or profile to a list or arbitrarily curating content) will be excluded from Hacktoberfest.

Hope to see some quality changes from your side next time. Remember: quantity is fun, and quality is key.

SanskritiGupta05 commented 1 year ago

Sure, I absolutely agree that quality is more important. That's why I wanted to add it, as it will eventually improve the dataset. No worries, I'll try to contribute in other ways. Thanks for replying! 😊

nikhil25803 commented 1 year ago

Yes, the college names will get refreshed once the respective Python files will run anyway, so populating it won't make a change.