Added Medical Colleges filters

Clueless-Community / collegeAPI

An API that helps you to fetch colleges and their details.

GNU General Public License v3.0

58 stars 61 forks source link

Added Medical Colleges filters #29

Closed smit-sms closed 2 years ago

smit-sms commented 2 years ago

Added Medical College filters and fixed multiple state filtering with state names having spaces in between. Solves issue: #25

nikhil25803 commented 2 years ago

Hey @smit-sms . Your code needs some changes., address the comment added.

smit-sms commented 2 years ago

@nikhil25803 What changes are exactly needed? I have already resolved the merge conflicts that were there in both files. Please let me know if any more changes are required.

nikhil25803 commented 2 years ago

@smit-sms

Replace the separating delimiter from ( , ) to ( & ) as a user will not use a comma in the URL, it will be like /state=bihar&jharkhand

smit-sms commented 2 years ago

@nikhil25803 Okay, sure. It will be the same for /city endpoints as well right?

nikhil25803 commented 2 years ago

Yes

smit-sms commented 2 years ago

@nikhil25803 I have fixed the changes as discussed. Please review.

nikhil25803 commented 2 years ago

Congrats 🎉, your PR got merged. To be eligible for the swags from iNeuron X ClueLess. Follow this steps.

SignIn / SignUp in ClueLess Website.
Go to profile section from the top right hand corner.
Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !

And don’t forget to share your achievement with your friends.

smit-sms commented 2 years ago

https://www.clueless.tech/profile/52400400 @nikhil25803