search

Clueless-Community / collegeAPI

An API that helps you to fetch colleges and their details.
GNU General Public License v3.0
58 stars 61 forks source link

Function concept is used to tackle line of code in filters.py #84

Closed OMH-G closed 2 years ago

OMH-G commented 2 years ago

Before

filters.py was using same computation to check state and city in json file it can be done with the help of function instead

After

Added one function which just passes state and city arguments to function and reduced overhead can you have a look @nikhil25803

nikhil25803 commented 2 years ago

Good work @OMH-G

Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow these steps.

  1. Star this repository. ⭐

  2. SignIn / SignUp in [[ClueLess Website](https://www.clueless.tech/)](https://www.clueless.tech/) .

  3. Go to the profile section from the top right-hand corner.

    https://s3.us-west-2.amazonaws.com/secure.notion-static.com/74339abf-adaf-4b25-8496-7642f08f7c03/Screenshot_2022-09-30_at_2.40.58_PM.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20220930%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20220930T091323Z&X-Amz-Expires=86400&X-Amz-Signature=346a58118a3686075c16e368b225e3c9ec7cb48c7a90c70903ff788e0812832f&X-Amz-SignedHeaders=host&response-content-disposition=filename%20%3D%22Screenshot%25202022-09-30%2520at%25202.40.58%2520PM.png%22&x-id=GetObject

  4. Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard!

And don’t forget to share your achievement with your friends.

OMH-G commented 2 years ago

Merged by : @nikhil25803 profile : https://www.clueless.tech/profile/109075344495625986648