search

Clueless-Community / collegeAPI

An API that helps you to fetch colleges and their details.
GNU General Public License v3.0
58 stars 61 forks source link

Optimization #96

Closed OMH-G closed 2 years ago

OMH-G commented 2 years ago

Before

Screenshot (216) In the response I have checked that it was returning 2D response

After

Using extend keyword instead of append keyword inside the api like engineering_colleges/state={state} worked and it returned 1D array as it will be better for further processing and extraction . Screenshot (217) can you have a closer look @nikhil25803 ? issue link : https://github.com/Clueless-Community/collegeAPI/issues/97#issue-1403102866

nikhil25803 commented 2 years ago

Great work @OMH-G

Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow these steps.

  1. Star this repository. ⭐
  2. SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
  3. Go to the profile section from the top right-hand corner.

https://s3.us-west-2.amazonaws.com/secure.notion-static.com/74339abf-adaf-4b25-8496-7642f08f7c03/Screenshot_2022-09-30_at_2.40.58_PM.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=AKIAT73L2G45EIPT3X45%2F20220930%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20220930T091323Z&X-Amz-Expires=86400&X-Amz-Signature=346a58118a3686075c16e368b225e3c9ec7cb48c7a90c70903ff788e0812832f&X-Amz-SignedHeaders=host&response-content-disposition=filename%20%3D%22Screenshot%25202022-09-30%2520at%25202.40.58%2520PM.png%22&x-id=GetObject

  1. Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard!

And don’t forget to share your achievement with your friends.

OMH-G commented 2 years ago

Merged by : @nikhil25803 profile : https://www.clueless.tech/profile/109075344495625986648